Skip to content

mergify: fix mergify config #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

mergify: fix mergify config #823

merged 1 commit into from
Jun 25, 2025

Conversation

@Nikhil-Ladha
Copy link
Contributor

@Nikhil-Ladha Nikhil-Ladha commented Jun 25, 2025

fix deprecated mergify config

@Nikhil-Ladha
mergify: fix mergify config
4bcc1ba 
fix deprecated mergify config

Signed-off-by: Nikhil-Ladha <[email protected]>
@Nikhil-Ladha Nikhil-Ladha requested a review from a team June 25, 2025 04:58
@Nikhil-Ladha
Copy link
Contributor Author

Nikhil-Ladha commented Jun 25, 2025

The mergify check fails for current config, but passes for the new config.
So, we should be good here.
Though, I am not sure if we need to manually merge the PR or so 🤔

@Nikhil-Ladha Nikhil-Ladha mentioned this pull request Jun 25, 2025
Merged
@iPraveenParihar
Copy link
Member

iPraveenParihar commented Jun 25, 2025

@Nikhil-Ladha do we have link to this config deprecation?

iPraveenParihar
iPraveenParihar previously approved these changes Jun 25, 2025
View reviewed changes
Copy link
Member

@iPraveenParihar iPraveenParihar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config LGTM.

@iPraveenParihar iPraveenParihar dismissed their stale review June 25, 2025 10:15

Actually, I noticed there is a PR from Mergify to update the config - #712

Can you compare your PR with it?

@Nikhil-Ladha
Copy link
Contributor Author

Nikhil-Ladha commented Jun 25, 2025

@Nikhil-Ladha do we have link to this config deprecation?

I couldn't find a link in the release docs or so, but the CI is failing with the details, as mentioned in my previous comment.

@Nikhil-Ladha
Copy link
Contributor Author

Nikhil-Ladha commented Jun 25, 2025

Actually, I noticed there is a PR from Mergify to update the config - #712

Can you compare your PR with it?

It has a similar change for the 2 fields which this PR adds, so we are good wrt that.

@iPraveenParihar
Copy link
Member

iPraveenParihar commented Jun 25, 2025

I think will need to merge it manually. @Rakshith-R PTAL

@nixpanic
Copy link
Collaborator

nixpanic commented Jun 25, 2025

@Mergifyio queue

Not sure this works...

@nixpanic
Copy link
Collaborator

nixpanic commented Jun 25, 2025

At least the new configuration is valid:
image

@nixpanic nixpanic merged commit 17a36e4 into csi-addons:main Jun 25, 2025
14 checks passed
@mergify
Copy link

mergify bot commented Jun 25, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]

@Nikhil-Ladha Nikhil-Ladha deleted the update-mergify branch June 26, 2025 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nixpanic nixpanic nixpanic approved these changes

@iPraveenParihar iPraveenParihar iPraveenParihar approved these changes

@Rakshith-R Rakshith-R Awaiting requested review from Rakshith-R

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Nikhil-Ladha @iPraveenParihar @nixpanic